Changes between Version 28 and Version 29 of Development/Patches


Ignore:
Timestamp:
Jun 25, 2017, 10:52:30 AM (15 months ago)
Author:
benl
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • Development/Patches

    v28 v29  
    1010 * For your first few patches, make a fork on !GitHub and send a pull request.
    1111 * After those have been accepted, we'll make you a direct committer to the !GitHub project.
    12  * The mirror is automatically updated from the !GitHub project once per day, but if you do lots of DDC hacking then we'll make you a direct account on the mirror as well.
    13  * The mirror is on the machine `deluge.ouroborus.net`, and `*.ouroborus.net` are aliases for it.
    14  * The buildbot and trac servers are also on `deluge.ouroborus.net`.
    15 
    16 == Mirror Push ==
    17 
    18  * For people with direct access to the mirror, use the following git commands so that your commits go to both repositories.
    19 {{{
    20 # Make a new remote named 'all' with GitHub as the default.
    21 git remote add all \
    22   ssh://git@github.com/DDCSF/ddc.git
    23 
    24 # Add a second URL for the mirror to the 'all' remote.
    25 git remote set-url --add all \
    26   ssh://DELUGEUSER@deluge.ouroborus.net/srv/code/www/ddc/ddc.git
    27 
    28 # To see if the setup worked use:
    29 git remote show all
    30 
    31 # To set 'all' to be the default upstream for push, use:
    32 git push -u all
    33 
    34 # Otherwise, you must explicitly select all for each push:
    35 git push all
    36 }}}
    3712
    3813== Testing ==
     
    6338== Handling Test Failures ==
    6439 * We don't like having failures in the main test suite.
    65  * If the nightly buildbot encounters a failure when running a test in a non-standard way (like with "opt") then someone should move that test into the {{{test/Broken-skip}}} directory and file a bug report.
     40 * If the nightly buildbot encounters a failure when running a test in a non-standard way (like with "opt") then someone should move that test into the {{{test/ddc-broken}}} directory and file a bug report.
    6641 * Don't push non-fixing patches into a repo that has test failures.
    6742
    6843== Fixing Bugs ==
    69  * Most of the bugs in the issue tracker should have a failing test case in {{{test/Broken-skip}}}
    70  * When you fix a bug, mark it as resolved on the trac then either move its test from {{{test/Broken-skip}}} into the main testsuite, or create a new test.
     44 * Most of the bugs in the issue tracker should have a failing test case in {{{test/ddc-broken}}}
     45 * When you fix a bug, mark it as resolved on the trac then either move its test from {{{test/ddc-broken}}} into the main test suite, or create a new test.
    7146 * If you find it too hard to create a new test, then we might need to extend the {{{war}}} test driver.